Fix Review

ethos/packages/contracts/contracts/errors/ReputationMarketErrors.sol

@@ -14,14 +14,9 @@ error MarketCreationUnauthorized(
   uint256 profileId
 );
 error InsufficientFunds();
-error InsufficientInitialLiquidity();
+error InsufficientLiquidity(uint256 creationCost);
 error InsufficientVotesOwned(uint256 profileId, address addressStr);
 error InsufficientVotesToSell(uint256 profileId);
-error SlippageLimitExceeded(
-  uint256 votesBought,
-  uint256 expectedVotes,
-  uint256 slippageBasisPoints
-);
 error InvalidMarketConfigOption(string message);
 error FeeTransferFailed(string message);
 error InactiveMarket(uint256 profileId);
@@ -30,3 +25,4 @@ error UnauthorizedWithdrawal();
 error MarketNotGraduated();
 error NoFundsToWithdraw();
 error ZeroAddressNotAllowed();
+error SellSlippageLimitExceeded(uint256 minimumPricePerVote, uint256 actualPricePerVote);

ethos/packages/contracts/contracts/errors/ReputationMarketErrors.sol.rej

@@ -0,0 +1,22 @@
+diff a/ethos/packages/contracts/contracts/errors/ReputationMarketErrors.sol b/ethos/packages/contracts/contracts/errors/ReputationMarketErrors.sol	(rejected hunks)
+@@ -14,14 +14,9 @@ error MarketCreationUnauthorized(
+   uint256 profileId
+ );
+ error InsufficientFunds();
+-error InsufficientInitialLiquidity();
++error InsufficientLiquidity(uint256 creationCost);
+ error InsufficientVotesOwned(uint256 profileId, address addressStr);
+ error InsufficientVotesToSell(uint256 profileId);
+-error SlippageLimitExceeded(
+-  uint256 votesBought,
+-  uint256 expectedVotes,
+-  uint256 slippageBasisPoints
+-);
+ error InvalidMarketConfigOption(string message);
+ error FeeTransferFailed(string message);
+ error InactiveMarket(uint256 profileId);
+@@ -30,3 +25,4 @@ error UnauthorizedWithdrawal();
+ error MarketNotGraduated();
+ error NoFundsToWithdraw();
+ error ZeroAddressNotAllowed();
++error SellSlippageLimitExceeded(uint256 minimumPricePerVote, uint256 actualPricePerVote);

ethos/packages/contracts/contracts/test/TestLMSR.sol

@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.26;
+
+import { LMSR } from "../utils/LMSR.sol";
+
+contract TestLMSR {
+  using LMSR for *;
+
+  function getOdds(
+    uint256 yesVotes,
+    uint256 noVotes,
+    uint256 liquidityParameter,
+    bool isTrust
+  ) external pure returns (uint256) {
+    return LMSR.getOdds(yesVotes, noVotes, liquidityParameter, isTrust);
+  }
+
+  function getCost(
+    uint256 currentYesVotes,
+    uint256 currentNoVotes,
+    uint256 outcomeYesVotes,
+    uint256 outcomeNoVotes,
+    uint256 liquidityParameter
+  ) external pure returns (int256) {
+    return
+      LMSR.getCost(
+        currentYesVotes,
+        currentNoVotes,
+        outcomeYesVotes,
+        outcomeNoVotes,
+        liquidityParameter
+      );
+  }
+}

ethos/packages/contracts/contracts/utils/Common.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 
 pragma solidity 0.8.26;
+error IndexOutOfBounds();
 
 contract Common {
   /**
@@ -30,8 +31,9 @@ contract Common {
    * @param array The storage array to modify
    * @notice This function will revert if the index is out of bounds
    */
+
   function _removeFromArray(uint256 index, address[] storage array) internal {
-    require(index < array.length, "Index out of bounds");
+    if (index >= array.length) revert IndexOutOfBounds();
 
     // If this is not the last element, copy last element to the index position
     if (index != array.length - 1) {

ethos/packages/contracts/contracts/utils/Common.sol.rej

@@ -0,0 +1,20 @@
+diff a/ethos/packages/contracts/contracts/utils/Common.sol b/ethos/packages/contracts/contracts/utils/Common.sol	(rejected hunks)
+@@ -1,6 +1,7 @@
+ // SPDX-License-Identifier: MIT
+
+ pragma solidity 0.8.26;
++error IndexOutOfBounds();
+
+ contract Common {
+   /**
+@@ -30,8 +31,9 @@ contract Common {
+    * @param array The storage array to modify
+    * @notice This function will revert if the index is out of bounds
+    */
++
+   function _removeFromArray(uint256 index, address[] storage array) internal {
+-    require(index < array.length, "Index out of bounds");
++    if (index >= array.length) revert IndexOutOfBounds();
+
+     // If this is not the last element, copy last element to the index position
+     if (index != array.length - 1) {

ethos/packages/contracts/contracts/utils/Constants.sol

@@ -9,5 +9,3 @@ string constant ETHOS_PROFILE = "ETHOS_PROFILE";
 string constant ETHOS_REVIEW = "ETHOS_REVIEW";
 string constant ETHOS_VOTE = "ETHOS_VOTE";
 string constant ETHOS_VOUCH = "ETHOS_VOUCH";
-string constant ETHOS_SLASH_PENALTY = "ETHOS_SLASH_PENALTY";
-string constant ETHOS_VAULT_MANAGER = "ETHOS_VAULT_MANAGER";

ethos/packages/contracts/contracts/utils/LMSR.sol

@@ -0,0 +1,179 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.26;
+
+import { UD60x18, unwrap, convert, exp } from "@prb/math/src/UD60x18.sol";
+
+/**
+ * @title LMSR
+ * @dev This library implements the Logarithmic Market Scoring Rule (LMSR) mechanism to calculate
+ *      odds and costs in a prediction market setting using a fixed-point arithmetic format
+ *      (UD60x18) for stable and precise computations.
+ *
+ * The LMSR model sets the cost of a given state based on the current quantities ("votes") of two
+ * opposing positions—like "yes" vs. "no." The relative prices adjust automatically as votes
+ * change, ensuring that no participant can gain a risk-free profit through arbitrage.
+ *
+ * Core formulas:
+ *
+ *     odds = e^(yes/b) / [ e^(yes/b) + e^(no/b) ]
+ *
+ *     cost = b * ln(e^(yes/b) + e^(no/b))
+ *
+ * - b is the liquidity parameter (higher b = more stable prices, but higher capital requirements)
+ * - yes and no are the count of "yes" and "no" votes respectively
+ *
+ * All returned values are UD60x18 fixed-point numbers, i.e., scaled by 1e18. These are dimensionless
+ * ratios. To convert them into a currency unit (like wei), you must multiply by a base price or
+ * scaling factor outside this library.
+ *
+ * MATHEMATICAL BOUNDS AND SAFETY:
+ * - The exp() function reverts if its input > ~133.084.
+ * - Therefore, (votes / b) must not exceed ~133.
+ * - In practice: votes ≤ 133 * b
+ *
+ * Example: If b = 1000, then max safe votes ≈ 133,000 per side.
+ *
+ * LIQUIDITY PARAMETER (b) GUIDELINES:
+ * - Recommended range: ~100-1,000,000
+ * - Smaller b: More volatility, lower capital requirements, risk of overflow with fewer votes.
+ * - Larger b: More stability, higher capital requirements, safer from overflow.
+ */
+
+library LMSR {
+  error VotesExceedSafeLimit(uint256 votes, uint256 liquidityParameter, uint256 maxSafe);
+
+  /**
+   * @notice Computes the current odds (yes or no) given the market state.
+   *
+   * The formula:
+   *     odds = e^(yes/b) / [ e^(yes/b) + e^(no/b) ]
+   *
+   * @param yesVotes Total number of "yes" votes currently in the market.
+   * @param noVotes Total number of "no" votes currently in the market.
+   * @param liquidityParameter The market's liquidity parameter (b).
+   * @param isYes If true, returns the odds for the "yes" side; if false, for the "no" side.
+   * @return ratio The current odds in a percentage from 0 to 1 (scaled up by 1e18).
+   */
+  function getOdds(
+    uint256 yesVotes,
+    uint256 noVotes,
+    uint256 liquidityParameter,
+    bool isYes
+  ) public pure returns (uint256 ratio) {
+    // Compute exponentials e^(yes/b) and e^(no/b)
+    (UD60x18 yesExp, UD60x18 noExp) = _getExponentials(yesVotes, noVotes, liquidityParameter);
+
+    // sumExp = e^(yes/b) + e^(no/b)
+    UD60x18 sumExp = yesExp.add(noExp);
+
+    // priceRatio = e^(yes/b)/(sumExp) if isYes, else e^(no/b)/(sumExp)
+    UD60x18 priceRatio = isYes ? yesExp.div(sumExp) : noExp.div(sumExp);
+
+    // Unwrap to get  scaled ratio
+    ratio = unwrap(priceRatio);
+  }
+
+  /**
+   * @notice Computes the incremental cost of changing the market state from
+   *         (currentYesVotes, currentNoVotes) to (outcomeYesVotes, outcomeNoVotes).
+   *
+   * This is computed as:
+   *     costDiff = cost(outcomeYesVotes, outcomeNoVotes) - cost(currentYesVotes, currentNoVotes)
+   *
+   * where:
+   *     cost = b * ln(e^(yes/b) + e^(no/b))
+   *
+   * @param currentYesVotes The current number of "yes" votes.
+   * @param currentNoVotes The current number of "no" votes.
+   * @param outcomeYesVotes The target number of "yes" votes after the trade.
+   * @param outcomeNoVotes The target number of "no" votes after the trade.
+   * @param liquidityParameter The market's liquidity parameter (b).
+   * @return costDiff The incremental cost difference, as an integral of the odds percentage (scaled up by 1e18).
+   */
+  function getCost(
+    uint256 currentYesVotes,
+    uint256 currentNoVotes,
+    uint256 outcomeYesVotes,
+    uint256 outcomeNoVotes,
+    uint256 liquidityParameter
+  ) public pure returns (int256 costDiff) {
+    uint256 oldCost = _cost(currentYesVotes, currentNoVotes, liquidityParameter);
+    uint256 newCost = _cost(outcomeYesVotes, outcomeNoVotes, liquidityParameter);
+    costDiff = int256(newCost) - int256(oldCost);
+  }
+
+  /**
+   * @dev Internal function implementing the LMSR cost formula:
+   *
+   *     cost = b * ln(e^(yes/b) + e^(no/b))
+   *
+   * Returns the cost in UD60x18 format (scaled by 1e18).
+   *
+   * @param yesVotes The number of "yes" votes.
+   * @param noVotes The number of "no" votes.
+   * @param liquidityParameter The market's liquidity parameter (b).
+   * @return costResult The cost value in UD60x18 format (scaled by 1e18).
+   */
+  function _cost(
+    uint256 yesVotes,
+    uint256 noVotes,
+    uint256 liquidityParameter
+  ) public pure returns (uint256 costResult) {
+    // Compute e^(yes/b) and e^(no/b)
+    (UD60x18 yesExp, UD60x18 noExp) = _getExponentials(yesVotes, noVotes, liquidityParameter);
+
+    // sumExp = e^(yes/b) + e^(no/b)
+    UD60x18 sumExp = yesExp.add(noExp);
+
+    // lnVal = ln(e^(yes/b) + e^(no/b))
+    UD60x18 lnVal = sumExp.ln();
+
+    // Unwrap lnVal and multiply by b (also in UD60x18) to get cost
+    uint256 lnValUnwrapped = unwrap(lnVal);
+    costResult = lnValUnwrapped * liquidityParameter;
+  }
+
+  /**
+   * @dev Computes e^(yes/b) and e^(no/b) using UD60x18 arithmetic. Reverts if
+   *      votes exceed the safe limit, which could cause overflow in exp().
+   *
+   * @param yesVotes The number of "yes" votes.
+   * @param noVotes The number of "no" votes.
+   * @param liquidityParameter The market's liquidity parameter (b).
+   * @return yesExp e^(yes/b) in UD60x18 format.
+   * @return noExp e^(no/b) in UD60x18 format.
+   *
+   * Reverts with VotesExceedSafeLimit if either vote count > 133 * b.
+   */
+  function _getExponentials(
+    uint256 yesVotes,
+    uint256 noVotes,
+    uint256 liquidityParameter
+  ) public pure returns (UD60x18 yesExp, UD60x18 noExp) {
+    // maxSafeRatio chosen as 133 since exp input ~133.084 causes overflow
+    uint256 maxSafeRatio = 133;
+
+    if (
+      yesVotes > maxSafeRatio * liquidityParameter || noVotes > maxSafeRatio * liquidityParameter
+    ) {
+      revert VotesExceedSafeLimit(
+        yesVotes > noVotes ? yesVotes : noVotes,
+        liquidityParameter,
+        maxSafeRatio * liquidityParameter
+      );
+    }
+
+    // Convert to UD60x18
+    UD60x18 yesUD = convert(yesVotes);
+    UD60x18 noUD = convert(noVotes);
+    UD60x18 b = convert(liquidityParameter);
+
+    // Compute ratios
+    UD60x18 yesRatio = yesUD.div(b);
+    UD60x18 noRatio = noUD.div(b);
+
+    // Compute exponentials
+    yesExp = exp(yesRatio);
+    noExp = exp(noRatio);
+  }
+}

ethos/packages/contracts/test/AccessControl.test.ts

@@ -16,8 +16,6 @@ const smartContractNames = {
   signatureVerifier: 'ETHOS_SIGNATURE_VERIFIER',
   vote: 'ETHOS_VOTE',
   vouch: 'ETHOS_VOUCH',
-  vaultManager: 'ETHOS_VAULT_MANAGER',
-  slashPenalty: 'ETHOS_SLASH_PENALTY',
 } as const;
 
 describe('AccessControl', () => {

ethos/packages/contracts/test/attestations/attestation.create.test.ts

@@ -29,7 +29,7 @@ describe('EthosAttestation Create Attestation', () => {
   const ATTESTATION_EVIDENCE_0 = 'ATTESTATION_EVIDENCE_0';
   // const ATTESTATION_EVIDENCE_1 = 'ATTESTATION_EVIDENCE_1';
 
-  const reAttest = async (): Promise<string> => {
+  async function reAttest(): Promise<string> {
     let signature = await common.signatureForCreateAttestation(
       '2',
       '3592832',
@@ -70,7 +70,7 @@ describe('EthosAttestation Create Attestation', () => {
       );
 
     return aHash;
-  };
+  }
 
   beforeEach(async () => {
     deployer = await loadFixture(createDeployer);