Upgrade to apollo-server 3 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also upgradees apollo-boost used in the tests to apollo-client. apollo-boost is now deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
I'm unsure if this breaks under apollo-server version 2.
Please Describe Your Changes
Hi! I'm new to Apollo and wanted to use this plugin, but it fails to compile with Apollo 3.
The details on why are here: https://www.apollographql.com/docs/apollo-server/migration/#plugin-api, specially this part:
I don't know if you want to have this change applied or not. I haven't tested if it still works for Apollo Server 2.
Besides the main upgrade, this also upgrades apollo-boost used in the tests to apollo-client since apollo-boost is now deprecated. but, unfortunately, this made lint fail with
error Missing file extension "cjs" for "@apollo/client/core" import/extensions. This import comes from here: https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#using-apollo-client-without-react and if we usefrom @apollo/client, it wants to add React as a dependency. The code works and compile fine, is just that lint throws this error.