Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate notify to v8 #1846

Merged
merged 2 commits into from
Jan 11, 2025

feat: notify 8.0 requires MSRV 1.77

88ed394
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(deps): update rust crate notify to v8 #1846

feat: notify 8.0 requires MSRV 1.77
88ed394
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy macos-latest succeeded Jan 11, 2025 in 0s

clippy macos-latest

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 488 in src/service/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/server.rs:484:61
    |
484 |               return Err(ShadowsocksError::InsufficientParams(format!(
    |  _____________________________________________________________^
485 | |                 "missing proxy servers, consider specifying it by \
486 | |                     --server-addr, --encrypt-method, --password command line option, \
487 | |                         or configuration file, check more details in https://shadowsocks.org/doc/configs.html"
488 | |             )));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
    |
484 ~             return Err(ShadowsocksError::InsufficientParams("missing proxy servers, consider specifying it by \
485 +                     --server-addr, --encrypt-method, --password command line option, \
486 ~                         or configuration file, check more details in https://shadowsocks.org/doc/configs.html".to_string()));
    |

Check warning on line 463 in src/service/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/manager.rs:460:50
    |
460 |               ShadowsocksError::InsufficientParams(format!(
    |  __________________________________________________^
461 | |                 "missing `manager_address`, consider specifying it by --manager-address command line option, \
462 | |                     or \"manager_address\" and \"manager_port\" keys in configuration file"
463 | |             ))
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
    |
460 ~             ShadowsocksError::InsufficientParams("missing `manager_address`, consider specifying it by --manager-address command line option, \
461 ~                     or \"manager_address\" and \"manager_port\" keys in configuration file".to_string())
    |

Check warning on line 945 in src/service/local.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

useless use of `format!` 

warning: useless use of `format!`
   --> src/service/local.rs:942:61
    |
942 |               return Err(ShadowsocksError::InsufficientParams(format!(
    |  _____________________________________________________________^
943 | |                 "missing `local_address`, consider specifying it by --local-addr command line option, \
944 | |                     or \"local_address\" and \"local_port\" in configuration file"
945 | |             )));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
    |
942 ~             return Err(ShadowsocksError::InsufficientParams("missing `local_address`, consider specifying it by --local-addr command line option, \
943 ~                     or \"local_address\" and \"local_port\" in configuration file".to_string()));
    |

Check warning on line 568 in crates/shadowsocks-service/src/local/tun/tcp.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

this lifetime isn't used in the function definition 

warning: this lifetime isn't used in the function definition
   --> crates/shadowsocks-service/src/local/tun/tcp.rs:568:37
    |
568 | async fn establish_client_tcp_redir<'a>(
    |                                     ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check warning on line 35 in crates/shadowsocks-service/src/local/redir/tcprelay/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy macos-latest

this lifetime isn't used in the function definition 

warning: this lifetime isn't used in the function definition
  --> crates/shadowsocks-service/src/local/redir/tcprelay/mod.rs:35:37
   |
35 | async fn establish_client_tcp_redir<'a>(
   |                                     ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
View more details on GitHub Actions