CTS: do not continue on error #4213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
previously approved these changes
May 23, 2024
jkwak-work
reviewed
May 23, 2024
kaizhangNV
force-pushed
the
issue/CTS
branch
3 times, most recently
from
920e6f5 to
260c099
Compare
The CTS nightly stops report error because of `continue-on-error` is set to true. Set it false such that we can know as soon as it fails. TODO: Temporarily change the workflow to run per-PR to verify thing is correct. Will change it back when the PR is ready to merge.
kaizhangNV
force-pushed
the
issue/CTS
branch
3 times, most recently
from
0fae5b3 to
c55e39a
Compare
kaizhangNV
force-pushed
the
issue/CTS
branch
2 times, most recently
from
b76e9b7 to
c3eebf9
Compare
|
because PR from forked branch cannot access the secret, I will delete this PR, and create a new one that will be submitted to slang repo directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS nightly stops report error because of
continue-on-erroris set to true. Set it false such that we can know as soon as it fails.