Cache address-space-legalization of kIROp_Store (#4480)

* Cache address-space-legalization of `kIROp_Store` without caching we will infinetly loop re-processing the same `kIROp_Store` * uncomment tests which should now work with metal * disable gfx backend failing tests
shader-slang · Jun 27, 2024 · 5dd8f29 · 5dd8f29
1 parent cb61011
commit 5dd8f29
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/source/slang/slang-ir-specialize-address-space.cpp b/source/slang/slang-ir-specialize-address-space.cpp
@@ -220,6 +220,7 @@ namespace Slang
                             if (addrSpace != AddressSpace::Generic)
                             {
                                 mapVarValueToAddrSpace[inst->getOperand(0)] = addrSpace;
+                                mapInstToAddrSpace[inst] = addrSpace;
                                 changed = true;
                             }
                         }

diff --git a/tests/language-feature/types/opaque/inout-param-opaque-type-in-struct.slang b/tests/language-feature/types/opaque/inout-param-opaque-type-in-struct.slang
@@ -4,6 +4,7 @@
 // aggregate type that includes an opaque type
 
 //TEST(compute):COMPARE_COMPUTE:
+// GFX backend fails
 //DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
 
 struct Things

diff --git a/tests/language-feature/types/opaque/inout-param-opaque-type.slang b/tests/language-feature/types/opaque/inout-param-opaque-type.slang
@@ -3,7 +3,7 @@
 // Test that a function/method can have an `out` parameter of opaque type
 
 //TEST(compute):COMPARE_COMPUTE:
-//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
+//TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
 
 //TEST_INPUT:set gX = ubuffer(data=[16 17 18 19], stride=4)
 RWStructuredBuffer<int> gX;

diff --git a/tests/language-feature/types/opaque/out-param-opaque-type-in-struct.slang b/tests/language-feature/types/opaque/out-param-opaque-type-in-struct.slang
@@ -4,6 +4,7 @@
 // aggregate type that includes an opaque type
 
 //TEST(compute):COMPARE_COMPUTE:
+// GFX backend fails
 //DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
 
 struct Things

diff --git a/tests/language-feature/types/opaque/out-param-opaque-type.slang b/tests/language-feature/types/opaque/out-param-opaque-type.slang
@@ -3,7 +3,7 @@
 // Test that a function/method can have an `out` parameter of opaque type
 
 //TEST(compute):COMPARE_COMPUTE:
-//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
+//TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
 
 //TEST_INPUT:set gThings = ubuffer(data=[16 17 18 19], stride=4)
 RWStructuredBuffer<int> gThings;

diff --git a/tests/language-feature/types/opaque/return-opaque-type-in-struct.slang b/tests/language-feature/types/opaque/return-opaque-type-in-struct.slang
@@ -4,6 +4,7 @@
 // aggregate type that includes an opaque type
 
 //TEST(compute):COMPARE_COMPUTE:
+// GFX backend fails
 //DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
 
 struct Things