fix(sidebar): add title and describe by #6294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now it is throwing: `DialogContent` requires a `DialogTitle` for the component to be accessible for screen reader users. If you want to hide the `DialogTitle`, you can wrap it with our VisuallyHidden component. For more information, see https://radix-ui.com/primitives/docs/components/dialog and warning: Warning: Missing `Description` or `aria-describedby={undefined}` for {DialogContent}.
|
@mikaelkristiansson is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
|
@mikaelkristiansson Is is happens only for Please follow through CONTRIBUTING.md guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now it is throwing:
DialogContentrequires aDialogTitlefor the component to be accessible for screen reader users.If you want to hide the
DialogTitle, you can wrap it with our VisuallyHidden component.For more information, see https://radix-ui.com/primitives/docs/components/dialog
and warning:
Warning: Missing
Descriptionoraria-describedby={undefined}for {DialogContent}.