Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: CI workflow update #2121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

thican
Copy link

@thican thican commented Jan 6, 2025

Avoid updates during CI, unexpected modifications happen, leading to job failures.

Should also be done for Docker images.

@nodiscc
Copy link
Member

nodiscc commented Jan 19, 2025

Is this the fix for #2126 ?

I did not have the time to investigate yet, tell me if you need help.

@nodiscc nodiscc added bug it's broken! tools developer tools labels Jan 19, 2025
@nodiscc nodiscc added this to the 0.14.1 milestone Jan 19, 2025
@thican
Copy link
Author

thican commented Jan 19, 2025

Is this the fix for #2126 ?

Yes it is.

I did not have the time to investigate yet, tell me if you need help.

In fact I do.

This is actually more complicated than I anticipated, as I am not a PHP developer, so I might be providing a wrong solution. And because I was busy since my last commits, I could not investigate more.
As far as I understood, the composer.lock file is used for all the currently supported PHP versions. Because of this, some third-party updates are "stuck" in a previous version while the later branch releases can pull more recent version, hence the composer update instruction in CI.

From my experience, CI should not pull and update project’s dependencies, otherwise this kind of issues happens. But then, later branch release is stuck as mentioned earlier.

What do you think?

@thican
Copy link
Author

thican commented Jan 19, 2025

Also, I forgot to mention, I don’t know which versions of dependencies match the actual code in the project, to I avoid to touch the content of composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! tools developer tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants