Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new until property to any event consumption strategies #997

Merged

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #992

What this PR does:

Added a new until property to any event consumption strategies

Additional information:

We need to find a smart way to forbid an until event consumption strategy to itself define the until property.

@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification labels Aug 28, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Aug 28, 2024
@cdavernas
Copy link
Member Author

@matthias-pichler Any suggestion on how to achieve the following in a brief, concise fashion?

We need to find a smart way to forbid an until event consumption strategy to itself define the until property.

schema/workflow.yaml Outdated Show resolved Hide resolved
@matthias-pichler
Copy link
Collaborator

@matthias-pichler Any suggestion on how to achieve the following in a brief, concise fashion?

We need to find a smart way to forbid an until event consumption strategy to itself define the until property.

Hmm we could do it with allOf

until:
  oneOf:
    - type: string
    - allOf:
        - $ref: #/$defs/eventConsumptionStrategy
        - type: object
          properties:
            until: false

@cdavernas cdavernas modified the milestones: v1.0.0-alpha3, v1.0.0 Oct 7, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cdavernas cdavernas merged commit db1b5ca into serverlessworkflow:main Jan 10, 2025
3 checks passed
@cdavernas cdavernas deleted the feat-listen-any-events-until branch January 10, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a new until (optional) property to Event Consumption Strategies of type any
3 participants