Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of eyre use for extract command #170

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Example of eyre use for extract command #170

wants to merge 1 commit into from

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Mar 7, 2024 •
edited
Loading

tarkah
tarkah commented Mar 7, 2024
View reviewed changes
moss/src/installation.rs
Comment on lines -227 to 230
#[error("Root is invalid")]
#[error("root is invalid")]
RootInvalid,
#[error("Cache dir is invalid")]
#[error("cache directory is invalid")]
CacheInvalid,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should our root library errors start capitalized or lowercase? 🤔 And then should all context be lowercase? Consistency here lends towards a nicer UX

@tarkah tarkah force-pushed the feat/better-errors branch from d45bfb4 to 82be174 Compare March 7, 2024 23:20
@ermo ermo added type: documentation Improvements or additions to documentation. type: enhancement New feature or request labels May 14, 2024
@ermo ermo added this to the zz -- deferred milestone May 14, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeycode ikeycode Awaiting requested review from ikeycode ikeycode will be requested when the pull request is marked ready for review ikeycode is a code owner

@ermo ermo Awaiting requested review from ermo ermo will be requested when the pull request is marked ready for review ermo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type: documentation Improvements or additions to documentation. type: enhancement New feature or request
Projects
No open projects
Tooling & Infra (current scope)
Status: No status
Milestone
zz -- deferred
Development

Successfully merging this pull request may close these issues.
3 participants
@tarkah @CLAassistant @ermo