Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support embedded album art covers #556

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turtletowerz
Copy link

@turtletowerz turtletowerz commented Jan 4, 2025

This adds complete support for embedded album art for any format that TagLib supports.

I'm marking this as a draft because there are a few code considerations I would like to get input on before continuing:

  1. The relevant audiotags package changes need to be made to sentriz/audiotags instead of linking to my personal repo. I did this for testing reasons but it will be removed before this is actually committed
  2. The way the cover cache path is passed around feels janky, and im wondering if there should be a more intentional settings or shared variables package.
  3. All of the embedded logic is shoved into tagcommon; not sure if this is appropriate or not

closes #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there support for album art embedded in the mp3 files?
1 participant