add custom HTTP headers to metrics-http-json.rb #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblaettler
force-pushed
the
feat/add-http-headers
branch
from
1e453c6 to
c8ca5f1
Compare
majormoses
reviewed
Mar 19, 2020
mblaettler
force-pushed
the
feat/add-http-headers
branch
from
8ab3d3d to
bf18fc9
Compare
Added -H/--header flag to pass custom HTTP headers in metrics-http-json.rb. This makes it possible to use authentication token or any other function based on HTTP headers. Co-Authored-By: Ben Abrams <[email protected]>
mblaettler
force-pushed
the
feat/add-http-headers
branch
from
bf18fc9 to
128b6a4
Compare
|
I squashed your changes into my commit. There was also a change in Line 95&96 required. In addition, I installed the plugin on our sensu instance to test it. It seems to work fine. |
|
I will try to get a release out tonight or tomorrow. |
Thank you very much. Have a nice day and stay healthy. :-) |
|
Sorry this slipped through I have cut a release and once CI passes it will be pushed to rubygems. I will check back later to make sure there are no hiccups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -H/--header flag to pass custom HTTP headers in metrics-http-json.rb.
This makes it possible to use authentication token or any other function based on HTTP headers.
Pull Request Checklist
Is this in reference to an existing issue?
#176
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
-> There was no entry about
metrics-http-json.rbyet.Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Currently it is not possible to pass custom HTTP headers to the request. This would be nice, because it would enable to use Authentication tokens or any other function based on HTTP headers.
Known Compatibility Issues