-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node docs #7368
Update node docs #7368
Conversation
|
||
Non-critical plugins run through a timeline that executes in order of insertion based on the entry type. Segment has these five entry types of non-critical plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silesky is there a reason why you deleted this before the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't delete the table? I updated the table to be accurate/relevant to nodejs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't say you deleted the table. I'm asking why you deleted line 406
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I misread! I thought the critical vs non critical category was more confusing that useful, and just added that information to the plug-in description of each plug-in type (i.e. Load errors can block the pipeline). This makes this table more like the analytics.js one
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Update node docs