Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artificial delay to find_illegal_dependencies #150

Closed
wants to merge 1 commit into from
Closed

Add artificial delay to find_illegal_dependencies #150

wants to merge 1 commit into from

Conversation

seddonym
Copy link
Owner

@seddonym seddonym commented Jun 6, 2024 •
edited
Loading

Adding a sleep doesn't seem to affect the benchmarking for some reason.

I've asked on the Codspeed discord: https://discord.com/channels/1065233827569598464/1249695480204755076/1249695480204755076

@seddonym seddonym marked this pull request as draft June 6, 2024 15:50
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #150 will degrade performances by 98.12%

Comparing codspeed-demo (eb03c2c) with master (cfb43d6)

Summary

❌ 2 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master codspeed-demo Change
❌ test_deep_layers_large_graph 5.8 s 77.3 s -92.45%
❌ test_top_level_large_graph 1.4 s 72.9 s -98.12%

@seddonym seddonym force-pushed the codspeed-demo branch 4 times, most recently from 05bc2fa to eb03c2c Compare June 11, 2024 15:03
@seddonym seddonym closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seddonym