-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC Configuration #122
Conversation
@@ -54,7 +56,7 @@ func InstallTrustedArtifactSigner(kc *kubernetes.KubernetesClient, tasNamespace, | |||
} | |||
} else { | |||
// if no values passed, use the default templated values | |||
tmpFile, err := ioutil.TempFile("", "values-*.yaml") | |||
tmpFile, err := os.CreateTemp("", "values-*.yaml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ioutil.TempFile() is deprecated, so I swapped it out for os.CreateTemp()
func InstallTrustedArtifactSigner(kc *kubernetes.KubernetesClient, tasNamespace, tasReleaseName, pathToValuesFile, chartVersion string) error { | ||
chartUrl := "oci://quay.io/redhat-user-workloads/arewm-tenant/sigstore-ocp/trusted-artifact-signer" | ||
func InstallTrustedArtifactSigner(kc *kubernetes.KubernetesClient, oidcConfig oidc.OIDCConfig, tasNamespace, tasReleaseName, pathToValuesFile, chartVersion string) error { | ||
chartUrl := "charts/trusted-artifact-signer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changed this to the local chart, as the oci one does not have a 0.1.26 tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh great! and I have a PR to make the chartURL configureable, so I'll pull in this change - this filesystem url will be the default until we have a stable OCI chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have a follow-up for the chartURL - we might rename it from chartURL to chartSomethingElse since with the local chart path it's not technically a URL - I'll add this to PR #127 though and let's merge this as/is!
This pr allows for the configuration of an OIDC provider with the tas installer
It adds three new flags to the installer --oidc-client-id, --oidc-issuer-url and --oidc-type