Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simulation to support #702] experiment latency improvement for lookup size reduce to half #704

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Dec 5, 2024

Preliminary to have some data to support #702

Mock opcode number of witness & lk expression to half

riscv_add 2^20

cargo bench --bench riscv_add --package ceno_zkvm -- --baseline baseline

results

add_op_20/prove_add/prove_add_log2_20
                        time:   [1.0732 s 1.0795 s 1.0861 s]
                        change: [-33.371% -31.731% -30.166%] (p = 0.00 < 0.05)

fibonacci 2^22 max steps

cargo bench --bench fibonacci --package ceno_zkvm -- --baseline baseline
fibonacci_max_steps_4194304/prove_fibonacci/fibonacci_max_steps_4194304
                        time:   [9.9614 s 10.160 s 10.360 s]
                        change: [-23.183% -21.087% -18.757%] (p = 0.00 < 0.05)
                        Performance has improved.

other notes in this simulation

some might be inaccurate in final real case

  • doesnt account for table proof m(x) SPARK + mpcs overhead, but we expect this overhead still much less than opcode prove.
  • only half of witness send to mpcs.commit + mpcs.opening. But they still play in main proof witness inferring. So this part in real situation will improve more. Beside we can reduce more constrain due to limb size from 2 -> 1
  • probably some opcode witness can be cut to more than half, some are less than half.

@hero78119 hero78119 marked this pull request as draft December 5, 2024 10:04
@hero78119 hero78119 changed the title [Mock data to support #702] experiment latency improvement for lookup reduce to half [Mock data to support #702] experiment latency improvement for lookup size reduce to half Dec 5, 2024
@hero78119 hero78119 changed the title [Mock data to support #702] experiment latency improvement for lookup size reduce to half [Simulation to support #702] experiment latency improvement for lookup size reduce to half Dec 5, 2024
@hero78119 hero78119 force-pushed the temp/lookup_size_half branch from eea35b7 to 8a2218a Compare December 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant