Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting "1" in action rolls #287

Merged

Conversation

Meathox
Copy link
Contributor

@Meathox Meathox commented Nov 8, 2023

Closes #285
Closes #282

I added the theme.palette.warning.light color to the roll.action result whent it's a 1 and added a text saying "Natural 1" under the actionResultLabel (same kind as the "Doubles" one).

If you'd like something different, say it and I"ll change ;)

@scottbenton
Copy link
Owner

I like it! The "Natural 1" text is a great addition I hadn't considered.
The only thing I'm not sold on is the styling for the "1" - not sure if the warning color is sufficient or if going for the error color is better. What do you think of these?

image

image

@Meathox
Copy link
Contributor Author

Meathox commented Nov 9, 2023

I like it! The "Natural 1" text is a great addition I hadn't considered. The only thing I'm not sold on is the styling for the "1" - not sure if the warning color is sufficient or if going for the error color is better. What do you think of these?

image

image

Oh that's nice! I'll try the one with the border. I though about underlining the 1 but wasn't really fond of the result when I tried.

And reverted to the default color
@Meathox
Copy link
Contributor Author

Meathox commented Nov 9, 2023

Changed it ! I also changed the color to pick the theme.primary.light. I think it looks better than a regular warning or error.

image
image

@scottbenton
Copy link
Owner

Great choice!

@scottbenton scottbenton merged commit 7792294 into scottbenton:prod Nov 9, 2023
2 of 4 checks passed
@Meathox Meathox deleted the feat/highlighting_1_action_rolls branch November 10, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight a score of 1 on an action die Add color coding to action rolls results
2 participants