fix(oracles): removed ask the oracle oracles from the list

scottbenton · Nov 14, 2023 · 5f53d02 · 5f53d02
1 parent aa355ad
commit 5f53d02
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -9,6 +9,7 @@
 - Added ability to remove lore, location, and NPC images by making them fullscreen and clicking the delete button
 - Moved Oracle tab to be with moves on desktop devices
 - Moved oracle pins to be in the oracle dialog to save space
+- Removed "Ask the Oracle" oracles from the oracle list, since they are pinned up top
 
 ### Accessibility
 

diff --git a/src/components/features/charactersAndCampaigns/OracleSection/OracleCategory.tsx b/src/components/features/charactersAndCampaigns/OracleSection/OracleCategory.tsx
@@ -3,7 +3,7 @@ import { useRoller } from "providers/DieRollProvider";
 import { OracleListItem } from "./OracleListItem";
 import { OracleSet } from "dataforged";
 import { useLinkedDialog } from "providers/LinkedDialogProvider";
-import { hiddenOracleIds } from "data/oracles";
+import { hiddenOracleCategoryIds } from "data/oracles";
 
 export interface OracleCategoryProps {
   prefix?: string;
@@ -23,6 +23,10 @@ export function OracleCategory(props: OracleCategoryProps) {
 
   const sampleNames = category["Sample Names" as "Sample names"];
 
+  if (hiddenOracleCategoryIds[category.$id]) {
+    return null;
+  }
+
   return (
     <>
       <List disablePadding>
@@ -56,7 +60,7 @@ export function OracleCategory(props: OracleCategoryProps) {
           )}
         {Object.keys(category.Tables ?? {}).map((oracleId, index) => {
           const oracle = category.Tables?.[oracleId];
-          if (hiddenOracleIds[oracleId] || !oracle) return null;
+          if (!oracle) return null;
           return (
             <OracleListItem
               id={oracle.$id}

diff --git a/src/data/oracles.ts b/src/data/oracles.ts
@@ -179,10 +179,7 @@ Object.keys(category).forEach((oracleCategoryId) => {
   };
 });
 
-export const hiddenOracleIds: { [oracleId: string]: boolean } = {
-  "ironsworn/oracles/moves/ask_the_oracle/almost_certain": true,
-  "ironsworn/oracles/moves/ask_the_oracle/likely": true,
-  "ironsworn/oracles/moves/ask_the_oracle/50_50": true,
-  "ironsworn/oracles/moves/ask_the_oracle/unlikely": true,
-  "ironsworn/oracles/moves/ask_the_oracle/small_chance": true,
+export const hiddenOracleCategoryIds: { [oracleId: string]: boolean } = {
+  "ironsworn/oracles/moves/ask_the_oracle": true,
+  "starforged/oracles/moves/ask_the_oracle": true,
 };