-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploaded newversion file #11
Conversation
powerexploit
commented
Mar 13, 2020
- To create newversion command or tool recommended as in Create a tool for automatic update versions #10 .
- I m implementing gitpython module to develop the kind of tool.
First of all, you have to add here a new command action_map['newversion'] = {
'add': 'add_new_version',
'show': 'show_changes',
} And here create a new python file called The import os
import shutil
from git import Repo
from git.exc import GitCommandError
class NewVersion(object): In to the file https://github.com/sclorg/container-workflow-tool/blob/master/container_workflow_tool/cli.py#L28 , you have to add a function like def newversion_usage(self):
return CliCommon.newversion_usage(self) % (self.prg_name, "") and the Similar to git_usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use proper indent spacing, which is important in python language.
I will test your code soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run your code and it needs to be better formated. You have Indention Errors.
Also newversion
command does not exist because of in constants.py
is missing dictionary.
See my comments.
@@ -36,4 +36,9 @@ | |||
actions['dockerhub'] = ['updatefulldescription', ] | |||
actions['utils'] = ['showconfig', 'listimages', 'listupstream', ] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions['newversion'] is missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take inspiration from the other cwt
subcommands like git
. This is a part of your job ;)
Closing this pull request. We will not implement it for now. |