Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold a SCIP pointer to prevent freeing the model while the constraint is still in use #158

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

mmghannam
Copy link
Member

@mmghannam mmghannam commented Oct 21, 2024

This is the second step for #151 that fixes use after free errors when using constraints after the model is freed.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (d56c177) to head (a7b9ef3).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/model.rs 86.96% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   75.67%   76.23%   +0.56%     
==========================================
  Files          13       13              
  Lines        1759     1805      +46     
==========================================
+ Hits         1331     1376      +45     
- Misses        428      429       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmghannam mmghannam merged commit 993d675 into main Oct 21, 2024
6 of 7 checks passed
@mmghannam mmghannam deleted the safe-scipref-cons branch October 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant