Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dict classes should produce instances of themselves #232

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

APN-Pucky
Copy link
Member

@APN-Pucky APN-Pucky commented Feb 20, 2024

LHEInit and LHEProcInfo inherit from dict. When parsing a string to either of them with fromstring it should return the corresponding class not a generic dict. They should have the same __init__ function as a dict for convenience.

* `LHEInit` and `LHEProcInfo` inherit from `dict`. When parsing a string
  to either of them with `fromstring` it should return the corresponding
  class not a generic dict. They should have the same `__init__` function
  as a `dict` for convenience.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (aefb63b) to head (c1d61a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files           2        2           
  Lines         235      235           
  Branches       54       54           
=======================================
  Hits          216      216           
  Misses         16       16           
  Partials        3        3           
Flag Coverage Δ
unittests-3.10 91.48% <100.00%> (ø)
unittests-3.8 91.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @APN-Pucky. This LGTM and I'd like this to go in before PR #233 so that things can be more atomic.

Can you please write a summary in the PR body of why this is needed, so that this can also get included in the squash and merge commit message?

@APN-Pucky
Copy link
Member Author

Can you please write a summary in the PR body of why this is needed, so that this can also get included in the squash and merge commit message?

Done

@matthewfeickert matthewfeickert merged commit 539cdb3 into scikit-hep:main Aug 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants