Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a warning when fitted parameter is at the bounds #2526

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

add additional todo comments

071c32a
Select commit
Loading
Failed to load commit list.
Draft

feat: create a warning when fitted parameter is at the bounds #2526

add additional todo comments
071c32a
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Jun 26, 2024 in 1s

3 issues found.

Annotations

Check notice on line 89 in src/pyhf/optimize/mixins.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/pyhf/optimize/mixins.py#L89

Unresolved comment '# TODO: check how to handle this for batching'. (C100)

Check notice on line 90 in src/pyhf/optimize/mixins.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/pyhf/optimize/mixins.py#L90

Unresolved comment '# TODO: handle skipping fixed parameters'. (C100)

Check notice on line 91 in src/pyhf/optimize/mixins.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/pyhf/optimize/mixins.py#L91

Unresolved comment '# TODO: handle various backends'. (C100)