Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure for tests #13

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Structure for tests #13

merged 3 commits into from
Jun 24, 2020

Conversation

eduardo-rodrigues
Copy link
Member

Hi, this PR starts adding some structure for tests as we have them in Scikit-HEP packages.

Starts addressing #12 and #4 to some extent.

With this I can see the tests running issuing python -m pytest tests/test.py -vv under the main directory. Of course there is no CI set up here, so that will have to come ...

@eduardo-rodrigues
Copy link
Member Author

Hi @ast0815, is this easy PR being forgotten …?

Copy link
Collaborator

@ast0815 ast0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make it so the output of the tests is printed to the logs? I.e. I'd like to be able to look at the histograms (even if it is without colour) that get produced. I'm not that familiar with pytest, but I think there is a command line flag that does this.

@eduardo-rodrigues
Copy link
Member Author

To be honest, @ast0815 I would prefer to do that or have it done in a different PR. For one, that's a different matter from this PR on structure. Also, I'm totally overloaded at the moment and do not exactly know how to do what you suggest, so no way I can do it "just now". But if you create an issue for your suggestion I will try and help next week.

If agreed, just approve, squash and merge :-).

.github/workflows/pythontests.yml Outdated Show resolved Hide resolved
@ast0815 ast0815 merged commit bff35ab into master Jun 24, 2020
@ast0815 ast0815 deleted the eduardo-tests-1 branch June 24, 2020 15:27
@ast0815
Copy link
Collaborator

ast0815 commented Jun 24, 2020

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants