-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle to 8.5 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update!
I have one question.
From now, do we support only Java 21 or later in Scalar Admin for Kubernetes?
In other words, from the perspective of Scalar Manager, is it OK to support only Java 21 or later?
(From the perspective of users, basically, they use pre-built binary or container image. So, I think there is no problem. However, I want to confirm it from the perspective of library users (mainly us).)
Sorry, I might have confused you. This change is for running the gradle wrapper, for example, For scalar-admin-for-kubernetes library, users can still integrate it with Java 8. (The class files in the JAR are still using major version 52 which Java 8 can run) My OS-level Java version is upgraded to 21 and I noticed my VSCode couldn't run Gradle so I upgraded the Gradle wrapper version to 8.5 based on this https://docs.gradle.org/current/userguide/compatibility.html |
@supl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR upgrades the build system to Gradle 8.5. This is mainly for building this project (running the gradle wrapper) with Java 21.
Related issues and/or PRs
N/A
Changes made
Checklist