Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 8.5 #28

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Upgrade Gradle to 8.5 #28

merged 1 commit into from
Jan 10, 2024

Conversation

supl
Copy link
Collaborator

@supl supl commented Jan 4, 2024

Description

This PR upgrades the build system to Gradle 8.5. This is mainly for building this project (running the gradle wrapper) with Java 21.

Related issues and/or PRs

N/A

Changes made

  • upgraded the Gradle wrapper

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

@supl supl self-assigned this Jan 4, 2024
Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!
I have one question.
From now, do we support only Java 21 or later in Scalar Admin for Kubernetes?
In other words, from the perspective of Scalar Manager, is it OK to support only Java 21 or later?
(From the perspective of users, basically, they use pre-built binary or container image. So, I think there is no problem. However, I want to confirm it from the perspective of library users (mainly us).)

@supl
Copy link
Collaborator Author

supl commented Jan 5, 2024

Thank you for the update! I have one question. From now, do we support only Java 21 or later in Scalar Admin for Kubernetes? In other words, from the perspective of Scalar Manager, is it OK to support only Java 21 or later? (From the perspective of users, basically, they use pre-built binary or container image. So, I think there is no problem. However, I want to confirm it from the perspective of library users (mainly us).)

@kota2and3kan

Sorry, I might have confused you.

This change is for running the gradle wrapper, for example, ./gradlew build with Java 21 but not about scalar-admin-for-kubernetes.

For scalar-admin-for-kubernetes library, users can still integrate it with Java 8. (The class files in the JAR are still using major version 52 which Java 8 can run)

My OS-level Java version is upgraded to 21 and I noticed my VSCode couldn't run Gradle so I upgraded the Gradle wrapper version to 8.5 based on this https://docs.gradle.org/current/userguide/compatibility.html

@supl supl requested a review from kota2and3kan January 5, 2024 05:11
@kota2and3kan
Copy link
Collaborator

@supl
I see. I understood.
Thank you for your explanation!

Copy link
Collaborator

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 515a74f into main Jan 10, 2024
5 checks passed
@feeblefakie feeblefakie deleted the gradle-8.5 branch January 10, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants