Transforming boolean or's and and's to if else blocks to preserve lazy evaluation. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transforming boolean or's and and's to if else blocks to preserve lazy evaluation when not already a jribble expression.
|
LGTM. Verified with all samples and work beautifully. |
gkossakowski
added a commit
that referenced
this pull request
Jan 30, 2012
Transforming boolean or's and and's to if else blocks to preserve lazy evaluation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest merge from scala master has exposed a bug in the jribble transformation phase.
scala.collection.immutable.Range now has a construct similar to {a || b} where b() contained side effects and the common case was for a to be true.
I've tracked down the issue and attempted to implement a fix with the guidance from Lex and Grzegorz.
I also tried to add a test but couldn't figure out how to get them to happily run.
See this thread for more details:
https://groups.google.com/forum/#!topic/scalagwt/vzL-e1pE-H8