-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C0 eth hooks upgrade #30
Draft
grothem
wants to merge
25
commits into
main
Choose a base branch
from
c0-eth-hooks-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change ~~ to relative path in order for eth-sdk to work when running contracts:external * only create LOCAL_PROVIDER when targetnetwork is localhost * target network back to default * catch import errors in webModalConfig * add try-catch for localhost static web3 provider config
* update action * #55 surge bug * #55 surge bug * #55 added is development flag * #55 fixed node external config for development and produciton * #57 remove ipfs client from ignore * #64 cleaned up files and added eslint rules to scaffold-eth-typescript * #64 changes to verbosity * #64 update packages * #64 updated environmental variables. made all keys env variables * #64 cleaned up environmental variables. made all keys env variables * #64 fixes for imports and eth-sdk * #64 minor changes * #64 minor changes * #64 action changes * push test comment * test test * testing * push test commit * Reverting test commits * push test commit * #64 minor fixes Co-authored-by: Mark Grothe <[email protected]>
…recated Greeter (#70) * Add chai and update sample-test.ts to use YourContract instead of deprecated Greeter * Oops -- yarn.lock too!
* fix fallback option for mainnet provider * fix typo
This works in combination with a layout fix for eth-components scaffold-eth/eth-components#42 When using eth-components with that fix, a css import from eth-components is necessary in scaffold-eth. So far, eth-components has had no .css to be imported by scaffold-eth. Only merge this once that PR in eth-components was merged and that code is actually used, otherwise we'll have a broken import. Co-authored-by: Shravan Sunder <[email protected]>
* #77 attempting to debug new error with web3modal * #77 attempting to debug new error with web3modal * #77 attempting to debug new error with web3modal * #77 attempting to debug new error with web3modal * #77 attempting to debug new error with web3modal * #77 update packages * #77 update yarn checksum behaviour * #77 update vite config
…h-typescript into c0-eth-hooks-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.