fix(core): revert lost changes from #7597

[pedrobonamin]

Description

In corel we lost some changes applied in #7597, this PR restores them.

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 7:02am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 7:02am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 7:02am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Jan 27, 2025 7:02am
test-next-studio	⬜️ Ignored (Inspect)			Jan 27, 2025 7:02am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Jan 27, 2025 7:06 AM (UTC)

❌ Failed Tests (2) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 7s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	1m 20s	5	0	1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	51s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 8s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 32s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	❌ Failed (Inspect)	2m 42s	20	0	1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 44s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Mon, 27 Jan 2025 07:07:53 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	22.7 efps (44ms)	22.5 efps (45ms)	+1ms (+1.1%)	✅
article (body)	63.3 efps (16ms)	63.1 efps (16ms)	+0ms (-/-%)	✅
article (string inside object)	25.6 efps (39ms)	24.7 efps (41ms)	+2ms (+3.8%)	✅
article (string inside array)	22.7 efps (44ms)	21.3 efps (47ms)	+3ms (+6.8%)	✅
recipe (name)	52.6 efps (19ms)	50.0 efps (20ms)	+1ms (+5.3%)	✅
recipe (description)	55.6 efps (18ms)	55.6 efps (18ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	18.5 efps (54ms)	17.7 efps (57ms)	+3ms (+4.6%)	✅
synthetic (string inside object)	18.5 efps (54ms)	18.9 efps (53ms)	-1ms (-1.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	44ms	56ms	82ms	476ms	1060ms	10.8s
article (body)	16ms	18ms	21ms	49ms	98ms	5.3s
article (string inside object)	39ms	41ms	48ms	54ms	134ms	6.7s
article (string inside array)	44ms	50ms	61ms	120ms	222ms	7.5s
recipe (name)	19ms	21ms	23ms	40ms	0ms	7.5s
recipe (description)	18ms	19ms	21ms	60ms	0ms	4.4s
recipe (instructions)	5ms	7ms	7ms	8ms	0ms	3.0s
synthetic (title)	54ms	57ms	61ms	306ms	855ms	13.1s
synthetic (string inside object)	54ms	56ms	65ms	625ms	917ms	9.2s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	45ms	69ms	77ms	459ms	891ms	11.1s
article (body)	16ms	19ms	24ms	92ms	263ms	5.5s
article (string inside object)	41ms	46ms	50ms	215ms	290ms	7.3s
article (string inside array)	47ms	49ms	56ms	262ms	247ms	7.4s
recipe (name)	20ms	23ms	27ms	44ms	0ms	7.4s
recipe (description)	18ms	19ms	21ms	59ms	0ms	4.6s
recipe (instructions)	5ms	6ms	7ms	8ms	0ms	3.0s
synthetic (title)	57ms	59ms	67ms	299ms	909ms	12.5s
synthetic (string inside object)	53ms	59ms	66ms	479ms	1338ms	9.1s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.

[RitaDias]

great catch 🚀