Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(e2e): first attempt at slight performance improvements #8225

Draft
wants to merge 492 commits into
base: next
Choose a base branch
from

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jan 9, 2025

Description

What to review

Testing

Notes for release

pedrobonamin and others added 30 commits October 28, 2024 15:47
Note: unarchiving is pending backend support
jordanl17 and others added 22 commits December 20, 2024 16:03
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 1:34pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 1:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 1:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 9, 2025 1:34pm
test-next-studio ⬜️ Ignored (Inspect) Jan 9, 2025 1:34pm

Copy link
Contributor

github-actions bot commented Jan 9, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Component Testing Report Updated Jan 9, 2025 1:37 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 9, 2025

⚡️ Editor Performance Report

Updated Thu, 09 Jan 2025 13:57:59 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 18.7 efps (54ms) +17ms (+44.6%) 🔴
article (body) 52.9 efps (19ms) 52.9 efps (19ms) +0ms (+0.0%)
article (string inside object) 27.0 efps (37ms) 20.0 efps (50ms) +13ms (+35.1%) 🔴
article (string inside array) 25.6 efps (39ms) 18.5 efps (54ms) +15ms (+38.5%) 🔴
recipe (name) 51.3 efps (20ms) 31.3 efps (32ms) +13ms (+64.1%) 🔴
recipe (description) 58.8 efps (17ms) 35.7 efps (28ms) +11ms (+64.7%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 18.9 efps (53ms) 7.6 efps (132ms) +79ms (+149.1%) 🔴
synthetic (string inside object) 20.0 efps (50ms) 7.9 efps (126ms) +76ms (+152.0%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 40ms 49ms 464ms 692ms 10.2s
article (body) 19ms 22ms 41ms 91ms 199ms 5.5s
article (string inside object) 37ms 40ms 44ms 244ms 249ms 6.6s
article (string inside array) 39ms 41ms 46ms 150ms 133ms 6.6s
recipe (name) 20ms 22ms 26ms 52ms 0ms 7.1s
recipe (description) 17ms 18ms 21ms 29ms 0ms 4.5s
recipe (instructions) 6ms 7ms 8ms 10ms 0ms 3.0s
synthetic (title) 53ms 57ms 63ms 243ms 794ms 12.2s
synthetic (string inside object) 50ms 56ms 87ms 465ms 1023ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 54ms 81ms 99ms 605ms 1705ms 13.7s
article (body) 19ms 21ms 29ms 91ms 147ms 5.7s
article (string inside object) 50ms 52ms 57ms 185ms 266ms 7.8s
article (string inside array) 54ms 58ms 62ms 146ms 703ms 7.9s
recipe (name) 32ms 35ms 43ms 69ms 0ms 8.3s
recipe (description) 28ms 30ms 32ms 50ms 20ms 5.4s
recipe (instructions) 6ms 7ms 8ms 32ms 0ms 3.1s
synthetic (title) 132ms 140ms 176ms 854ms 6565ms 20.7s
synthetic (string inside object) 126ms 143ms 192ms 881ms 6765ms 16.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias changed the base branch from corel to next January 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants