VTT writer: port SRT writer improvments (#343) #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palemieux
reviewed
Oct 19, 2021
| def normalize_eol(self): | ||
| """Remove line breaks at the beginning and end of the paragraph, and replace | ||
| line break sequences with a single line break""" | ||
| self._text = VttParagraph._EOL_SEQ_RE.sub("\n", self._text).strip("\n\r") |
There was a problem hiding this comment.
What about also normalizing whitespaces per #350?
There was a problem hiding this comment.
@palemieux I think #350 is not critical as xml:preserve is not used (at least from observation) very often, if at all. It is also not recommended to use it because the result can not be predicted and depends on the selection of fonts. So I think it is safe to wait with this issue and prioritize other issues higher. If the review is OK for this PR it is ready to be merged from my view.
palemieux
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343