ADD getRefreshRate #95
Merged
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until implemented in C:
https://devforum.play.date/t/getrefreshrate-in-c/20746
I think the api is straitforward enough to assume the if it gets added to C eventually, it'll have the same signature and we can transparently remove this stopgap local bookkeeping solution. API also matches the lua api
The big advantage of implementing this in playdate-nim rather thhan game code is that this way it is guaranteed that the value is in sync with the actual refreshrate, since there is only 1 possible codepath. ie. it is not possible to call setRefreshRate this way without also updating the variable