Fix/align button state names #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, yes please create a clean PR that just addresses the naming issue. |
ADD .idea yo .gitignore
|
.idea files removed from codebase and added to .gitignore instead |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to me like the goal is to copy the C api names and a small typo slipped in:
button**s**State.I would prefer the version without the extra s at least.
This is a breaking change, but I guess we will be fine with that in the current state of the project.
It seems that I already merged the idea files in my own main branch, so probably you want to merge that one before this PR. That'll leave just the nim files which this PR is about.
Otherwise, I can re-create this PR in a clean way