Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wordsize detection for LoongArch64. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dandan336
Copy link

Compiling the marisa failed for loongarch64 in my local system.

$ git clone https://github.com/s-yata/marisa-trie.git
$ cd marisa-trie
$ autoreconf -i
$ ./configure
$ make
$ make check

The results of make check are as follows,

make[3]: Entering directory '/home/zdd/marisa-trie/tests'
FAIL: base-test
PASS: io-test
PASS: vector-test
PASS: trie-test
PASS: marisa-test
============================
Testsuite summary for marisa 0.2.6
============================
# TOTAL: 5
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

I have added wordsize detection for LoongArch64, please review.
I have also submitted a bug request to Debian BTS, the BugID can be found at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065467
BTW, the documentations of the LoongArch architecture can be found at the following links,
ISA: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html

thanks,
Dandan Zhang

ncopa added a commit to ncopa/marisa-trie that referenced this pull request Apr 24, 2024
Detect the MARISA_WORD_SIZE independent of architecture.

Fixes: s-yata#40
Fixes: s-yata#57
Fixes: s-yata#44
Fixes: s-yata#46
Fixes: s-yata#56
@ncopa
Copy link

ncopa commented Apr 24, 2024

There is a better way to solve this: #58

ncopa added a commit to ncopa/marisa-trie that referenced this pull request Apr 30, 2024
Detect the MARISA_WORD_SIZE independent of architecture.

Fixes: s-yata#40
Fixes: s-yata#57
Fixes: s-yata#44
Fixes: s-yata#46
Fixes: s-yata#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants