sctk_binary_path variable in Hub5ScoreJob #292
Conversation
Co-authored-by: michelwi <[email protected]>
Co-authored-by: michelwi <[email protected]>
Co-authored-by: michelwi <[email protected]>
|
I added your suggested changes. I thought about removing str in the annotations, as well but wasn't sure, if in that case, we would also like to remove appearances of tk.uncached_path in the Hub5ScoreJob as suggested in #32 the way it's done in ScliteJob already. What's your opinion? |
sure, lets do it. |
|
|
||
| ref = self.ref | ||
| try: | ||
| ref = shutil.copy(tk.uncached_path(ref), ".") | ||
| ref = shutil.copy(ref.get_path(), ".") | ||
| except shutil.SameFileError: |
There was a problem hiding this comment.
I am wondering: why are we copying ref and hyp?
There was a problem hiding this comment.
how can this be the same file?? "." should be the job work dir, correct? ergo this should not be the same file
There was a problem hiding this comment.
why are we copying ref and hyp?
dunno.
how can this be the same file??
maybe during automatic LM scale optimization?
|
moving the copy of ref and hyp to a new issue #293 |
* Add sctk_binary_path variable to Hub5ScoreJob and add type annotations. * Reformat. * Update type annotations Co-authored-by: michelwi <[email protected]> * Update docstring Co-authored-by: michelwi <[email protected]> * Update imports. Co-authored-by: michelwi <[email protected]> * Remove tk.uncached_path. Co-authored-by: Daniel Mann <[email protected]> Co-authored-by: michelwi <[email protected]>
The use of binary path variables in the sisyphus.global_settings might become deprecated in the future (as discussed in #254). This is a slight change of the Hub5ScoreJob similar to the ScliteJob in this direction. Moreover, some type annotations have been added to the init signature.