Implement *WasmAbi for array #2013
Conversation
c410-f3r
force-pushed
the
array-impls
branch
2 times, most recently
from
5a4521d to
9ed3400
Compare
src/convert/slices.rs
Outdated
| #[inline] | ||
| fn into_abi(self) -> Self::Abi { | ||
| WasmSlice { | ||
| ptr: self.as_ptr().into_abi(), |
There was a problem hiding this comment.
I believe this is a use-after-free, right? self is dropped at the end of this function but we're returning a pointer to it?
There was a problem hiding this comment.
Hehehe. I should have paid more attention instead of simply copying and pasting. Thank you
c410-f3r
force-pushed
the
array-impls
branch
from
9ed3400 to
44253ba
Compare
|
@alexcrichton At the time, there were some concerns about the feasibility of this feature. Has anything changed since then? |
|
Unfortunately, no, not much has changed I believe. |
|
@alexcrichton Thank you ! With the imminent stabilization of constant generics, it is unfortunate that this feature can't be implemented. |
|
Sup @alexcrichton Is it still not possible to implement this feature? |
|
I know I need this functionality. |
WIP
Requesting review because this is a blind attempt to implement
*WasmAbifor arrays (up to 32). Sincerely, I am not aware of the consequences of these changes, let alone the possible missing places required for this feature.