use assert_eq! and _ne!, remove uneeded parens
#3082
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jan 9, 2025
| @@ -804,7 +804,7 @@ If you encounter an error missing from this list, please file an issue or a PR!" | |||
| self.current_module | |||
| ); | |||
|
|
|||
| self.items[(self.current_module.0).0] | |||
| self.items[self.current_module.0 .0] | |||
There was a problem hiding this comment.
This change looks drive-by but alright.
There was a problem hiding this comment.
sorry, i forgot to include it in the description - i actually fixed a number of these too as part of this PR. Updated.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nyurik
changed the title
assert_eq|_ne instead of assert!assert_eq! and _ne!, remove uneeded parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert!toassert_eq!andassert_ne!where possible