speexdsp

Fix unnecessary parentheses warnings #219

Sign in to view logs

GitHub Actions / clippy succeeded Jun 14, 2024 in 0s

clippy

14 warnings

Details

Results

Message level	Amount
Internal compiler error	0
Error	0
Warning	14
Note	0
Help	0

Versions

rustc 1.79.0 (129f3b996 2024-06-10)
cargo 1.79.0 (ffa9cf99a 2024-06-03)
clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 195 in fft/tests/fftwrap.rs

github-actions / clippy

casting raw pointers to the same type and constness is unnecessary (`*mut i32` -> `*mut i32`)

warning: casting raw pointers to the same type and constness is unnecessary (`*mut i32` -> `*mut i32`)
   --> fft/tests/fftwrap.rs:195:13
    |
195 |             original_drft_lookup.splitcache as *mut i32,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `original_drft_lookup.splitcache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 187 in fft/tests/fftwrap.rs

github-actions / clippy

casting raw pointers to the same type and constness is unnecessary (`*mut f32` -> `*mut f32`)

warning: casting raw pointers to the same type and constness is unnecessary (`*mut f32` -> `*mut f32`)
   --> fft/tests/fftwrap.rs:187:13
    |
187 |             original_drft_lookup.trigcache as *mut f32,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `original_drft_lookup.trigcache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 178 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/sse3.rs:178:19
    |
178 |         out_slice[(out_stride * out_sample)] = hsum_m128d(accum) as f32;
    |                   ^                       ^
    |
help: remove these parentheses
    |
178 -         out_slice[(out_stride * out_sample)] = hsum_m128d(accum) as f32;
178 +         out_slice[out_stride * out_sample] = hsum_m128d(accum) as f32;
    |

Check warning on line 115 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/sse3.rs:115:19
    |
115 |         out_slice[(out_stride * out_sample)] =
    |                   ^                       ^
    |
help: remove these parentheses
    |
115 -         out_slice[(out_stride * out_sample)] =
115 +         out_slice[out_stride * out_sample] =
    |

Check warning on line 76 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/sse3.rs:76:19
   |
76 |         out_slice[(out_stride * out_sample)] =
   |                   ^                       ^
   |
help: remove these parentheses
   |
76 -         out_slice[(out_stride * out_sample)] =
76 +         out_slice[out_stride * out_sample] =
   |

Check warning on line 137 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/avx.rs:137:19
    |
137 |         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
    |                   ^                       ^
    |
help: remove these parentheses
    |
137 -         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
137 +         out_slice[out_stride * out_sample] = hsum_m256d(accum) as f32;
    |

Check warning on line 78 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/avx.rs:78:19
   |
78 |         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
   |                   ^                       ^
   |
help: remove these parentheses
   |
78 -         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
78 +         out_slice[out_stride * out_sample] = hsum_m256d(accum) as f32;
   |

Check warning on line 46 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/avx.rs:46:19
   |
46 |         out_slice[(out_stride * out_sample)] =
   |                   ^                       ^
   |
   = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
   |
46 -         out_slice[(out_stride * out_sample)] =
46 +         out_slice[out_stride * out_sample] =
   |

Check warning on line 178 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/sse3.rs:178:19
    |
178 |         out_slice[(out_stride * out_sample)] = hsum_m128d(accum) as f32;
    |                   ^                       ^
    |
help: remove these parentheses
    |
178 -         out_slice[(out_stride * out_sample)] = hsum_m128d(accum) as f32;
178 +         out_slice[out_stride * out_sample] = hsum_m128d(accum) as f32;
    |

Check warning on line 115 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/sse3.rs:115:19
    |
115 |         out_slice[(out_stride * out_sample)] =
    |                   ^                       ^
    |
help: remove these parentheses
    |
115 -         out_slice[(out_stride * out_sample)] =
115 +         out_slice[out_stride * out_sample] =
    |

Check warning on line 76 in resampler/src/speex/sse3.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/sse3.rs:76:19
   |
76 |         out_slice[(out_stride * out_sample)] =
   |                   ^                       ^
   |
help: remove these parentheses
   |
76 -         out_slice[(out_stride * out_sample)] =
76 +         out_slice[out_stride * out_sample] =
   |

Check warning on line 137 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
   --> resampler/src/speex/avx.rs:137:19
    |
137 |         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
    |                   ^                       ^
    |
help: remove these parentheses
    |
137 -         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
137 +         out_slice[out_stride * out_sample] = hsum_m256d(accum) as f32;
    |

Check warning on line 78 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/avx.rs:78:19
   |
78 |         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
   |                   ^                       ^
   |
help: remove these parentheses
   |
78 -         out_slice[(out_stride * out_sample)] = hsum_m256d(accum) as f32;
78 +         out_slice[out_stride * out_sample] = hsum_m256d(accum) as f32;
   |

Check warning on line 46 in resampler/src/speex/avx.rs

github-actions / clippy

unnecessary parentheses around index expression

warning: unnecessary parentheses around index expression
  --> resampler/src/speex/avx.rs:46:19
   |
46 |         out_slice[(out_stride * out_sample)] =
   |                   ^                       ^
   |
   = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
   |
46 -         out_slice[(out_stride * out_sample)] =
46 +         out_slice[out_stride * out_sample] =
   |

View more details on GitHub Actions