Remove mutex around LLVM calls from booster #4087
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the LLVM backend was not thread-safe so the simplification calls had to be sequentialised for concurrent RPC requests. Since thread-local storage is now used, the calls can be executed concurrently/in parallel using multiple cores. This PR removes the mutex that sequentialised the calls before.
jberthold
force-pushed
the
enable-parallel-calls-to-llvm
branch
from
8d90457 to
070305f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the LLVM backend was not thread-safe so the simplification calls had to be sequentialised for concurrent RPC requests.
Since thread-local storage is now used, the calls can be executed concurrently/in parallel using multiple cores. This PR removes the mutex that sequentialised the calls before.
This change should be tested in combination with K release 7.1.198 or higher (LLVM backend using thread-local storage).