Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new symbol-overload attribute #3722

Closed
wants to merge 1 commit into from
Closed

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Feb 16, 2024

Fixes #nnnn

Scope:

Estimate:


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@jberthold
Copy link
Member

Thanks for starting this work!
I was looking into this on Friday but wanted to upgrade the K dependency first to integration-test things properly. This upgrade is still in progress at #3691

@jberthold
Copy link
Member

I opened #3723 with your commit plus some (textual) adjustments on top of the changes required to upgrade K for the tests (the latter should be rebased out later)

@Baltoli
Copy link
Contributor Author

Baltoli commented Feb 19, 2024

Superseded by #3723

@Baltoli Baltoli closed this Feb 19, 2024
@Baltoli Baltoli deleted the symbol-overload branch February 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants