Remove references to #parseKORE
#3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2023
Scott-Guest
force-pushed
the
parse-kore-no-more
branch
from
1cbf9f1 to
28ad01d
Compare
rv-jenkins
pushed a commit
to runtimeverification/k
that referenced
this pull request
Dec 7, 2023
Per discussion in the frontend meeting, this PR removes `#parseKORE` because it is - deprecated in modern K in favor of Pyk-based approaches - unused by all of our active semantics - type unsafe (and I am on a crusade to patch all type safety violations :smile:) Related: runtimeverification/llvm-backend#919, runtimeverification/haskell-backend#3701
Baltoli
approved these changes
Dec 7, 2023
rv-jenkins
pushed a commit
to runtimeverification/llvm-backend
that referenced
this pull request
Dec 7, 2023
This PR removes the deprecated `#parseKORE` hook. Dependencies before merge: runtimeverification/k#3850, runtimeverification/haskell-backend#3701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all references to the deprecated
#parseKOREhookPaired with runtimeverification/k#3850, runtimeverification/llvm-backend#919