Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch IOError when a query times out and retry correctly #3692

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

goodlyrottenapple
Copy link
Contributor

@goodlyrottenapple goodlyrottenapple commented Nov 1, 2023

This (hopefully) fixes runtimeverification/k#3729, specifially the error below, thrown here

kore-exec: [41516716] Error (ErrorException):
    user error (Unexpected result from the SMT solver:
      Command: (push 1 )
      Expected: success
      Result: (error "line 178 column 8: push canceled" )
    )

This error occurs when smt-limit is low and we send an assert query to the solver. When this happens, we want to re-try instead of letting the error bubble up, as it currently does.

I have tested this and confirmed that at a threshold level of smt-timeout where Z3 fails intermittently, with this change, we re-try the specified number of times before failing fully.

@goodlyrottenapple goodlyrottenapple marked this pull request as ready for review November 1, 2023 14:57
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job tracking this down!

@goodlyrottenapple goodlyrottenapple merged commit eebe4e9 into master Nov 2, 2023
7 checks passed
@goodlyrottenapple goodlyrottenapple deleted the sam/smt-catch-cancelled branch November 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource exhaustion in CI can break release builds
3 participants