Allow global settings on Grape::Entity. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced after merging a ruby-grape#134. It's something undocumented before but it worked before and I don't see anything harmful in the presence of this feature. Fixes ruby-grape#166. Conflicts: .rubocop_todo.yml CHANGELOG.md lib/grape_entity/entity.rb lib/grape_entity/version.rb spec/grape_entity/entity_spec.rb
marshall-lee
force-pushed
the
fix_global_settings_master
branch
from
ae847ca to
84060a7
Compare
|
Interesting. |
dblock
added a commit
that referenced
this pull request
Aug 10, 2015
Allow global settings on Grape::Entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced after merging a #134.
It's something undocumented before but it worked before and I don't see
anything harmful in the presence of this feature.
Fixes #166.
Port of #167