Fix offenses for InternalAffairs/OnSendWithoutOnCSend cop
#76
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop recently added a new internal cop to detect cops which do define `on_send` and do not define `on_csend` (safe navigation). I've fixed some cops to detect offenses in this case (where it made sense). ref: rubocop/rubocop#13510
viralpraxis
deleted the
fix-internal-affairs-on-send-without-on-csend-cop
branch
mikegee
reviewed
Jan 23, 2025
Comment on lines
+50
to
+51
| Thread&.new { do_work } | ||
| ^^^^^^^^^^^ #{msg} |
There was a problem hiding this comment.
Yeah, this construct does not make much sense in practice. But I thought that since technically this is still an issue to detect (Thread.new is the same as Thread&.new in runtime) it's easier to just do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop recently added a new internal cop to detect cops which do define
on_sendand do not defineon_csend(safe navigation).I've fixed some cops to detect offenses in this case (where it made sense).
ref: rubocop/rubocop#13510