Add support assert_empty, assert_not_empty and refute_empty for RSpec/Rails/MinitestAssertions
#1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Jan 11, 2024
pirj
reviewed
Jan 11, 2024
pirj
approved these changes
Jan 11, 2024
ydah
force-pushed
the
support-assert-empty
branch
from
6095eb7 to
9d402fe
Compare
ydah
force-pushed
the
support-assert-empty
branch
from
9d402fe to
4d3da80
Compare
pirj
reviewed
Jan 11, 2024
pirj
reviewed
Jan 11, 2024
ydah
force-pushed
the
support-assert-empty
branch
from
4d3da80 to
62c0ab5
Compare
bquorning
reviewed
Jan 11, 2024
bquorning
reviewed
Jan 11, 2024
| "expect(#{@actual.source}).#{runner}(eq(#{@expected.source})," \ | ||
| " #{@fail_message.source})" |
There was a problem hiding this comment.
I will enable Layout/LineContinuationLeadingSpace in a later PR 😉
ydah
force-pushed
the
support-assert-empty
branch
from
62c0ab5 to
a23d4e6
Compare
|
Thank you for review. I updated this PR. |
bquorning
approved these changes
Jan 11, 2024
13 tasks
G-Rath
reviewed
Jan 11, 2024
|
This is a really cool addition and refactor! I love having the dedicated mini classes for each assertion group |
… `RSpec/Rails/MinitestAssertions`
ydah
force-pushed
the
support-assert-empty
branch
from
de8cdd4 to
32eb847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add support
assert_empty,assert_not_emptyandrefute_emptyforRSpec/Rails/MinitestAssertions.Related to rubocop/rubocop-rspec_rails#7
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).