-
-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Require RuboCop 1.30+ as runtime dependency
This PR makes RuboCop Performance require RuboCop 1.30+ to fix some errors: https://github.com/rubocop/rubocop-performance/actions/runs/6966652446/job/18957154150 It introduces CI for the oldest RuboCop version still supported, implementing a workflow for regression testing that is similar to the one found a rubocop/rubocop-rails@c9acb7a.
- Loading branch information
Showing
4 changed files
with
38 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
oldest_supported_rubocop: | ||
runs-on: ubuntu-latest | ||
name: The oldest supported RuboCop version | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Use the oldest supported RuboCop | ||
run: | | ||
sed -e "/gem 'rubocop', github: 'rubocop\/rubocop'/d" \ | ||
-e "/gem 'rubocop-rspec',/d" -i Gemfile | ||
cat << EOF > Gemfile.local | ||
gem 'rubocop', '1.30.0' # Specify the oldest supported RuboCop version | ||
EOF | ||
- name: set up Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: 2.7 | ||
bundler-cache: true | ||
- name: spec | ||
run: bundle exec rake spec |
1 change: 1 addition & 0 deletions
1
changelog/change_require_rubocop_1_33_as_a_runtime_dependency.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* [#388](https://github.com/rubocop/rubocop-performance/pull/388): Require RuboCop 1.30+ as runtime dependency. ([@koic][]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters