Merge pull request #38 from larouxn/remove_mdx_support

Remove mdx support as it appears bugged
rubocop · Sep 13, 2024 · 09ebd29 · 09ebd29
2 parents 8ade436 + 602adbd
commit 09ebd29
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 18 deletions.
diff --git a/config/default.yml b/config/default.yml
@@ -10,18 +10,17 @@ Markdown:
 # Keep in sync with MARKDOWN_EXTENSIONS
 Layout/CommentIndentation: &markdown_excludes
   Exclude:
-    - '**/*.md'
-    - '**/*.livemd'
-    - '**/*.markdown'
-    - '**/*.mdown'
-    - '**/*.mdwn'
-    - '**/*.mdx'
-    - '**/*.mkd'
-    - '**/*.mkdn'
-    - '**/*.mkdown'
-    - '**/*.ronn'
-    - '**/*.scd'
-    - '**/*.workbook'
+    - "**/*.md"
+    - "**/*.livemd"
+    - "**/*.markdown"
+    - "**/*.mdown"
+    - "**/*.mdwn"
+    - "**/*.mkd"
+    - "**/*.mkdn"
+    - "**/*.mkdown"
+    - "**/*.ronn"
+    - "**/*.scd"
+    - "**/*.workbook"
 
 Layout/LeadingCommentSpace:
   <<: *markdown_excludes

diff --git a/lib/rubocop/markdown/rubocop_ext.rb b/lib/rubocop/markdown/rubocop_ext.rb
@@ -2,7 +2,6 @@
 
 module RuboCop
   module Markdown # :nodoc:
-    # According to Linguist. mdx was dropped but is being kept for backwards compatibility.
     # See https://github.com/github-linguist/linguist/blob/8c380f360ce00b95fa08d14ce0ebccd481af1b33/lib/linguist/languages.yml#L4088-L4098
     # Keep in sync with config/default.yml
     MARKDOWN_EXTENSIONS = %w[
@@ -11,7 +10,6 @@ module Markdown # :nodoc:
       .markdown
       .mdown
       .mdwn
-      .mdx
       .mkd
       .mkdn
       .mkdown

diff --git a/test/fixtures/file_extensions/05.mdx b/test/fixtures/file_extensions/05.mdx
diff --git a/test/integration_test.rb b/test/integration_test.rb
@@ -68,7 +68,6 @@ def test_file_extensions
     assert_includes res, "file_extensions/02.markdown:"
     assert_includes res, "file_extensions/03.mdown:"
     assert_includes res, "file_extensions/04.mdwn:"
-    assert_includes res, "file_extensions/05.mdx:"
     assert_includes res, "file_extensions/06.mkd:"
     assert_includes res, "file_extensions/07.mkdn:"
     assert_includes res, "file_extensions/08.mkdown:"