Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add excel serializer/parser #975

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

r2evans
Copy link

@r2evans r2evans commented Jan 23, 2025

Fixes #973
Fixes #959

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just missing tests for the serializer and parser

Feel free to duplicate how parquet approached them:

Thank you!

@@ -588,6 +620,7 @@ register_parsers_onLoad <- function() {
register_parser("rds", parser_rds, fixed = "application/rds")
register_parser("feather", parser_feather, fixed = c("application/vnd.apache.arrow.file", "application/feather"))
register_parser("parquet", parser_parquet, fixed = "application/vnd.apache.parquet")
register_parser("excel", parser_excel, fixed = c("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", "application/vnd.ms-excel"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call. = FALSE)
}

serializer_write_file(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for me... writexl::write_xlsx() can not leverage the changes in #972 as write_xl is expecting a file string and does not return a raw vector here: https://github.com/ropensci/writexl/blob/7c06c338cdddc0cc1c078afe3173a71a6efe33ff/src/write_xlsx.c#L209

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bummer

@r2evans
Copy link
Author

r2evans commented Jan 27, 2025

Just missing tests for the serializer and parser

You can't see the uncommitted new-file tests/testthat/test-serializer-excel.R on my local computer? (Oops)

@r2evans
Copy link
Author

r2evans commented Jan 27, 2025

@schloerke should be good now, tests are confirmed committed, devtools::test() is clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants