Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark invalid pegin as processed #2929

Open
wants to merge 6 commits into
base: feature/powpeg_validation_protocol-integration
Choose a base branch
from

Conversation

nathanieliov
Copy link
Contributor

Mark rejected pegins as processed once RSKIP459 is active.

Motivation and Context

Peg-in transactions rejected by the Bridge should be marked as processed to ensure that the rejected_pegin event is emitted only once per transaction.

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

@nathanieliov nathanieliov requested a review from a team January 13, 2025 15:07
Copy link

github-actions bot commented Jan 13, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@nathanieliov nathanieliov marked this pull request as ready for review January 13, 2025 17:01
…jected pegin should be marked as processed

- Update BridgeSupportRegisterBtcTransactionTest to assert rejected pegin are marked as processed since RSKIP459
- Add tests asserting rejected pegin are marked as processed once RSKIP459 is active
- Make logic handling rejected pegin functional using the Optional API
- Fix formatting
- Enhance switch for processing each PeginProcessAction
@marcos-iov marcos-iov force-pushed the invalid-pegin-as-processed-integration-rebased branch from b877d0a to da9c490 Compare January 13, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant