Remove spendableValueFromProposedFed constant and use minPegoutTxValue directly #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
apancorb
approved these changes
Jan 9, 2025
|
marcos-iov
reviewed
Jan 9, 2025
| provider.setSvpFundTxHashUnsigned(svpFundTransactionUnsigned.getHash()); | ||
| PegoutsWaitingForConfirmations pegoutsWaitingForConfirmations = provider.getPegoutsWaitingForConfirmations(); | ||
|
|
||
| List<UTXO> utxosToUse = federationSupport.getActiveFederationBtcUTXOs(); | ||
| settleReleaseRequest(utxosToUse, pegoutsWaitingForConfirmations, svpFundTransactionUnsigned, rskTxHash, spendableValueFromProposedFederation); | ||
| // minPegoutValue to proposed fed, minPegoutValue to flyover proposed fed | ||
| Coin totalValueSentToProposedFederation = bridgeConstants.getMinimumPegoutTxValue().multiply(2); |
There was a problem hiding this comment.
Can we get this value from the transaction inputs? Feel like it will be more robust that way, a change in the transaction will automatically be reflected here
marcos-iov
approved these changes
Jan 9, 2025
marcos-iov
merged commit ed6d032
into
feature/powpeg_validation_protocol-phase4
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.