Feature/powpeg validation protocol phase4 #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate processValidationFailure method Correct log Correct test class name Modify clearSvpValues to know and log which stage failed. Add tests for new behavior Add fund tx signed hash log Make events vbles static Refactor clearSvpValues to make code more functional
…be called from support. Assert any of svp values are present when clearing value. Add missing blank line Make logging more accurate when clearing svp values in provider. Minor refactor for clearing svp values in support Correct test
Minor refactors to avoid duplication code Rewrite comment Fix sonar complains Handle exception when processing fund transaction. Add logs for when updating svp state Add debug level log for when proposed fed does not exist Not allow validation period end block to be part of validation ongoing period Make updateSvpState private. Call it from updateCollections Add missing import Fix test
…e called from bridge
Use Stream.toList() to ensure lists are unmodifiable Add a new value for pre lovell activation age in testnet
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Remove spendableValueFromProposedFed constant and use minPegoutTxValue directly
Do not shuffle fundTx outputs order
Rollback change in fund tx value
Remove assert methods that do not return void
|
marcos-iov
approved these changes
Jan 10, 2025
marcos-iov
merged commit 8f3af1d
into
feature/powpeg_validation_protocol-integration
9 checks passed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the fourth -and last- phase of the PowPeg Spendability Protocol as specified in RSKIP419
Description
Define proposed-federation related CallTransaction.Function s in
Bridgeclass.Return active and retiring federations creation time in seconds instead of milliseconds.
Add methods to clear svp related values.
Use new java17 switch when registering a peg transaction.
Create method called from updateCollections to update svp state.
Refactor and renaming.
Set
shuffleOutputs = falseto fund transaction send request so the outputs are always put in the same order.Change wrong amount being sent in spend tx.
Remove spent utxos after creating fund tx.
Create new
SVP_FUND_TXandSVP_SPEND_TXin PegTxType enum.Create new
FederationContextclass to have all the federations-related information.Move some javadocs from
BridgeSupporttoFederationSupport.Use the
FederationChangeFunctionsenum when executing vote federation change instead of using strings.Use new java17 switch when executing a federation change function.
Increase federation validation period in testnet and regtest.
How Has This Been Tested?
Types of changes
Checklist: