feat(rpc): adds revert data to eth_call

[jurajpiar]

Adds revert data to the eth_call response if failed.

Description

• Created a new ProgramRevert class to combine revert reason and revert data.
• Changed decodeProgramRevert (formerly decodeProgramRevertMessage) to return ProgramRevert
• Modified RskJsonRpcRequestException to accept ProgramRevert
• Modified basic unit test test_revertedTransaction to check for this revert data
• ...TBC

Motivation and Context

How Has This Been Tested?

• [WIP] Unit tests
• Integration test TBD

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[Vovchyk]

don't forget to pass this data value to JsonError in RskErrorResolver

[jurajpiar]

pipeline:run

[fmacleal]

Good job!

I have few comments, if you have any doubt, let me know and I we disccuss it.

[jurajpiar]

pipeline:run

[fmacleal]

Nice, good job!

[nagarev]

LGTM

[0xM3R]

Here are some further improvement proposal RskJsonRpcRequestException.java although they aren't direct security risk items:

• The byte[] revertData field should rather be declared as immutable to prevent unexpected modification if any unexpected Java runtime exception occurs. Therefore e defensive copies of revertData byte can be used in the constructor and getter.
  i.e.

   protected RskJsonRpcRequestException(Integer code, @Nullable byte[] revertData, String message, Exception e) {
        super(message, e);
        this.code = code;
        this.revertData = (revertData != null) ? revertData.clone() : null; // Defensive copy
    }

• @Nullable fields handling mechanism can be improved in a way to ensure more robust handling of nulls correctly to prevent NullPointerException
  i.e.

public static RskJsonRpcRequestException transactionRevertedExecutionError(
            @Nonnull String revertReason,
            @Nonnull byte[] revertData

fixed by the requester

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud