Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null response #2262

Merged
merged 42 commits into from
Mar 5, 2024
Merged

Handle null response #2262

merged 42 commits into from
Mar 5, 2024

Conversation

marcos-iov
Copy link
Contributor

@marcos-iov marcos-iov commented Mar 4, 2024

ci:rc600-modifier
fed:ARROWHEAD-6.0.0-rc
rit:ARROWHEAD-6.0.0-rc

Vovchyk and others added 30 commits February 16, 2024 12:35
- Use propagated message type from Program in Bridge
- Add verification per Bridge method about the acceptedt message type
- Include check in Bridge execution to avoid executing method with restricted message type

This is a WIP and not ready for production yet.
@marcos-iov marcos-iov requested a review from a team as a code owner March 4, 2024 20:16
new String[]{"string[]"}
),
fixedCost(76000L),
(BridgeMethodExecutorTyped) Bridge::getBtcBlockchainBlockLocator,

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Bridge.getBtcBlockchainBlockLocator
should be avoided because it has been deprecated.
@marcos-iov
Copy link
Contributor Author

pipeline:run

Copy link

sonarqubecloud bot commented Mar 4, 2024

Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Vovchyk Vovchyk merged commit 15f1669 into ARROWHEAD-6.0.0-rc Mar 5, 2024
10 checks passed
@Vovchyk Vovchyk deleted the handle-null-response branch March 5, 2024 13:07
@aeidelman aeidelman added this to the Arrowhead 6.0.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants